-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #95
Conversation
Pull Request Test Coverage Report for Build 751
💛 - Coveralls |
Add the --no-git-reset flag to the lerna publish command to publish reglardless of git status
Hopefully fixes an error related to that package not being found
Later versions seem to transform special characters
Looks good to me. I'd like to consider removing some things which might not be needed anymore (travis, circleci, chai) and apart from that I'd suggest that we ask a few people to whether they're able to run this locally (@krakenfuss , @abertelle @malte-wessel ) before merging it in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me 💯 Few things are remaining from my side #119 . I'll create a separate PR.
Long overdue updating of dependencies and our build system.
link:
instead oflerna bootstrap
(Improve documentation / faq to cover these points lerna/lerna#1788)An alternative to the
link:
scheme would be to rely on yarn workspaces.Suggestion would be to update rollup, typescript & babel afterwards.