Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #95

Merged
merged 33 commits into from
Apr 25, 2019
Merged

Update dependencies #95

merged 33 commits into from
Apr 25, 2019

Conversation

pago
Copy link
Contributor

@pago pago commented Jan 13, 2019

Long overdue updating of dependencies and our build system.

An alternative to the link: scheme would be to rely on yarn workspaces.
Suggestion would be to update rollup, typescript & babel afterwards.

@coveralls
Copy link

coveralls commented Jan 13, 2019

Pull Request Test Coverage Report for Build 751

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.556%

Totals Coverage Status
Change from base Build 665: 0.03%
Covered Lines: 2166
Relevant Lines: 2295

💛 - Coveralls

@pago pago requested a review from ayusharma March 19, 2019 12:07
@pago
Copy link
Contributor Author

pago commented Apr 16, 2019

Looks good to me. I'd like to consider removing some things which might not be needed anymore (travis, circleci, chai) and apart from that I'd suggest that we ask a few people to whether they're able to run this locally (@krakenfuss , @abertelle @malte-wessel ) before merging it in.

Copy link
Collaborator

@ayusharma ayusharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me 💯 Few things are remaining from my side #119 . I'll create a separate PR.

@pago pago merged commit 617386e into master Apr 25, 2019
@pago pago deleted the update-deps branch April 25, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants